Fix Recent Trips Actions #1369
Fix Recent Trips Actions #1369
Conversation
lib/components/form/user-settings.js
Outdated
| if (queryWithoutModes.departArrive === 'NOW') { | ||
| queryWithoutModes.departArrive = 'DEPART' | ||
| } |
There was a problem hiding this comment.
Just an idea, but instead of populating the d/t selector to reflect the time the trip was originally planned, could we set the d/t selector by default to "today/leave now"? Or even avoid changing the d/t selector? I think in most cases the user is going to be trying to re-plan the trip for a time in the future versus look at results for a time that's in the past
There was a problem hiding this comment.
I agree. User is most likely trying to plan the same trip again but now. Should we have it set to "leave now" instead?
There was a problem hiding this comment.
That might be out of the scope of this PR though?
There was a problem hiding this comment.
826d860 leaves the settings of the date time selector as they were prior to selecting the recent search entry, let me know what you think @amy-corson-ibigroup and @miles-grant-ibigroup
lib/components/form/user-settings.js
Outdated
| if (queryWithoutModes.departArrive === 'NOW') { | ||
| queryWithoutModes.departArrive = 'DEPART' | ||
| } |
There was a problem hiding this comment.
I agree. User is most likely trying to plan the same trip again but now. Should we have it set to "leave now" instead?
lib/components/form/user-settings.js
Outdated
| if (queryWithoutModes.departArrive === 'NOW') { | ||
| queryWithoutModes.departArrive = 'DEPART' | ||
| } |
There was a problem hiding this comment.
That might be out of the scope of this PR though?
binh-dam-ibigroup
requested review from
miles-grant-ibigroup and
amy-corson-ibigroup
binh-dam-ibigroup
assigned miles-grant-ibigroup and amy-corson-ibigroup and unassigned binh-dam-ibigroup
Description
This PR addresses incorrect behavior when clicking a recent search:
PR Checklist: